-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
packages/carbon-graphs/tests/unit/controls/Bar/AxisInfoRow.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/carbon-graphs/tests/unit/controls/Bar/BarPanning.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alla Doroshkevych <[email protected]>
Co-authored-by: Alla Doroshkevych <[email protected]>
Co-authored-by: Alla Doroshkevych <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just questions or nits, shall approve upon addressing.
@@ -87,7 +87,7 @@ describe('Bar - Panning', () => { | |||
|
|||
expect(() => { graphDefault.reflow(panData); }).toThrowError(errors.THROW_MSG_INVALID_DATA); | |||
}); | |||
it('throws error when undefined value is passed as y', () => { | |||
it('throws aan error when y is passed as undefined', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling nit: aan
-> an
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this got updated in: 6cf7494
]; | ||
|
||
const plugins = [ | ||
'@babel/plugin-proposal-object-rest-spread', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not in this PR but I believe this is the deprecated version of this plugin. If you're continuing work on this it might be a good idea to use @babel/plugin-transform-object-rest-spread like we're doing here with the other babel plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out! I'll make that change in the next PR.
Summary
This PR updates the repo to utilize Jest for unit tests instead of Karma. Since there are a large amount of tests to go over, this PR narrows the scope to only the Bar graph. Other graph types and unit tests will be updated in subsequent PRs.
Note: A small subset of tests are failing due to differing values or due to an undefined value in the graph API. These tests are being skipped for now as they require dedicated debugging and the current objective is to switch over to Jest for unit tests. These failing tests will be fixed in a separate Jira.
Testing
This change was tested using:
The CICD was switched over to utilize Jest and it is currently passing:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9813
Thank you for contributing to Terra.
@cerner/terra